Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v4.4.26 #1210

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Release v4.4.26 #1210

merged 1 commit into from
Jul 20, 2022

Conversation

dvaldivia
Copy link
Collaborator

Signed-off-by: Daniel Valdivia [email protected]

@dvaldivia dvaldivia self-assigned this Jul 19, 2022
cniackz
cniackz previously approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Daniel :)

bexsoft
bexsoft previously approved these changes Jul 19, 2022
View reviewed changes
@dvaldivia
Release v4.4.26
3a8e44c 
Signed-off-by: Daniel Valdivia <[email protected]>
@dvaldivia dvaldivia dismissed stale reviews from cniackz and bexsoft via 3a8e44c July 19, 2022 16:34
@cniackz cniackz self-requested a review July 19, 2022 16:34
cniackz
cniackz approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donatello
Copy link
Member

donatello commented Jul 19, 2022 •
edited
Loading

Noting that minio/minio#15270 needs to go in as soon as this is merged to avoid OpenID related breakage.

@harshavardhana
Copy link
Member

Noting that minio/minio#15270 needs to go in as soon as this is merged to avoid OpenID related breakage.

what will break? @donatello

@donatello
Copy link
Member

donatello commented Jul 19, 2022 •
edited
Loading

what will break? @donatello

@harshavardhana MinIO needs that change, so console will work with OpenID as expected (for a single claim based provider), because we have changed the way console receives the openid config.

Oops that's for console release, not operator, my bad.

@harshavardhana harshavardhana merged commit fee3007 into minio:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjuarezd pjuarezd pjuarezd approved these changes

@cniackz cniackz cniackz approved these changes

@reivaj05 reivaj05 reivaj05 approved these changes

@bexsoft bexsoft bexsoft approved these changes

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

@Alevsk Alevsk Awaiting requested review from Alevsk

Assignees

@dvaldivia dvaldivia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dvaldivia @donatello @harshavardhana @pjuarezd @cniackz @reivaj05 @bexsoft