Add option to disable TLS on minio #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
previously requested changes
Jul 18, 2022
kubectl-minio/cmd/tenant-create.go
Outdated
| @@ -82,6 +82,7 @@ func newTenantCreateCmd(out io.Writer, errOut io.Writer) *cobra.Command { | |||
| f.BoolVar(&c.tenantOpts.DisableAntiAffinity, "enable-host-sharing", false, "[TESTING-ONLY] disable anti-affinity to allow pods to be co-located on a single node (unsupported in production environment)") | |||
| f.StringVar(&c.tenantOpts.KmsSecret, "kes-config", "", "name of secret for KES KMS setup, refer https://github.com/minio/operator/blob/master/examples/kes-secret.yaml") | |||
| f.BoolVar(&c.tenantOpts.EnableAuditLogs, "enable-audit-logs", true, "Enable/Disable audit logs") | |||
| f.BoolVar(&c.tenantOpts.EnableTLS, "enable-tls", true, "Enable/Disable TLS") | |||
There was a problem hiding this comment.
It is simply easier to take --disable-tls as an option instead of --enable-tls=false WDYT? @pjuarezd
There was a problem hiding this comment.
I am good with that, --disable-tls . It was a little tricky because default values are not a good inicator of whether the parameter was set or not by the user, change is pushed in latest commit
we disable tls if and only the flag is present, regardless of what value the user assigns
dvaldivia
approved these changes
Jul 19, 2022
bexsoft
approved these changes
Jul 19, 2022
dvaldivia
dismissed
harshavardhana’s stale review
comments were addressed and the flag changed to disable-tls
Alevsk
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.