Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tenant.features.bucketDNS and tenant.features.domains to tenant helm chart #1193

Merged
merged 1 commit into from
Jul 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions helm/tenant/templates/tenant.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,15 @@ spec:
{{- toYaml . | nindent 6 }}
{{- end }}
requestAutoCert: {{ dig "certificate" "requestAutoCert" false . }}
s3:
bucketDNS: {{ dig "s3" "bucketDNS" false . }}
{{- if dig "s3" "bucketDNS" false . }}
{{- fail "Value 'tenant.s3.bucketDNS' is deprecated since Operator v4.3.2, use 'tenant.features.bucketDNS' instead" }}
{{- end }}
features:
bucketDNS: {{ dig "features" "bucketDNS" false . }}
{{- with (dig "features" "domains" (dict) .) }}
domains:
{{- toYaml . | nindent 6 }}
{{- end }}
{{- with (dig "buckets" (list) .) }}
buckets:
{{- toYaml . | nindent 4 }}
Expand Down
8 changes: 4 additions & 4 deletions helm/tenant/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,11 @@ tenant:
## for the auto-generated certificate. Internal DNS name for the pod will be used if CommonName is
## not provided. DNS name format is *.minio.default.svc.cluster.local
certConfig: { }
## Enable S3 specific features such as Bucket DNS which would allow `buckets` to be
## accessible as DNS entries of form `<bucketname>.minio.default.svc.cluster.local`
s3:
## This feature is turned off by default
## MinIO features to enable or disable in the MinIO Tenant
## https://github.com/minio/operator/blob/master/docs/crd.adoc#features
features:
bucketDNS: false
domains: { }
## List of bucket names to create during tenant provisioning
buckets: [ ]
## List of secret names to use for generating MinIO users during tenant provisioning
Expand Down