Properly use custom kubeconfig for all clientsets #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
harshavardhana,
dvaldivia,
Alevsk,
cniackz and
reivaj05
harshavardhana
force-pushed
the
fix/kubeconfig
branch
from
53bdca4 to
b6f95bd
Compare
neoaggelos
force-pushed
the
fix/kubeconfig
branch
from
b6f95bd to
8286de6
Compare
|
Rebased against latest branch. |
|
Ping, is this waiting for something? |
neoaggelos
force-pushed
the
fix/kubeconfig
branch
from
ace6f38 to
fbaf567
Compare
|
pinging again |
neoaggelos
force-pushed
the
fix/kubeconfig
branch
from
fbaf567 to
b4595c6
Compare
|
Hello, rebased again. Apologies for bumping the PR repeatedly, but we would greatly benefit from this fix. Is it possible to move this forward? Thank you |
|
PTAL @dvaldivia @Alevsk @cniackz |
|
Hi, any updates on this? Thanks! |
cniackz
approved these changes
Aug 9, 2022
harshavardhana
approved these changes
Aug 9, 2022
reivaj05
pushed a commit
to reivaj05/operator
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1109
Notes
This change works for me. I think it would make sense to pull the
clientcmd.ClientConfigcreation in a separate function to avoid code duplication (and similar issues in the future), but I decided against it, as it touches more parts of the codebase than I believe are required.I'd be willing to go ahead with the change if the maintainers find that it is OK.