Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fields as per S3 specification #1618

Conversation

balamurugana
Copy link
Member

@balamurugana balamurugana commented Jan 23, 2025

  • listBuckets(ListBucketsArgs) breaks backward compatibility due to
    unlimited bucket listing

harshavardhana
harshavardhana previously approved these changes Jan 23, 2025
@balamurugana balamurugana force-pushed the Add-missing-fields-as-per-S3-specification branch from 0fc2947 to 2dc3195 Compare January 23, 2025 08:28
@balamurugana balamurugana marked this pull request as draft January 23, 2025 08:29
@balamurugana balamurugana force-pushed the Add-missing-fields-as-per-S3-specification branch 2 times, most recently from 0ee6b79 to cdceb4b Compare January 23, 2025 12:27
@balamurugana balamurugana marked this pull request as ready for review January 23, 2025 12:28
@balamurugana balamurugana force-pushed the Add-missing-fields-as-per-S3-specification branch 3 times, most recently from bd5d6ef to e58019e Compare January 24, 2025 03:31
* listBuckets(ListBucketsArgs) breaks backward compatibility due to
  unlimited bucket listing

Signed-off-by: Bala.FA <[email protected]>
@balamurugana balamurugana force-pushed the Add-missing-fields-as-per-S3-specification branch from e58019e to 1005fa8 Compare January 24, 2025 07:27
Copy link

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

}

@Root(name = "EventBridgeConfiguration")
public static class EventBridgeConfiguration {}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we plan to implement this in future with details?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see any fields in S3 specification. It is empty ATM

@balamurugana balamurugana merged commit 0f533e8 into minio:master Jan 25, 2025
8 checks passed
@balamurugana balamurugana deleted the Add-missing-fields-as-per-S3-specification branch January 25, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants