Skip to content

Commit

Permalink
Remove assume-role provider functional test
Browse files Browse the repository at this point in the history
`play.minio.io` setup is meant to change configuration and
running assume-role provider tests is not valid against it.
  • Loading branch information
balamurugana committed Nov 18, 2020
1 parent 9f9c9f9 commit cc93af1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 42 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ jobs:
java-version: ${{ matrix.java-version }}
- name: Set environment variables
run: |
echo "::set-env name=DEV_VERSION::$(./gradlew properties | awk '/^version:/ { print $2 }')"
echo "::set-env name=RELEASE_VERSION::$(./gradlew properties -Prelease | awk '/^version:/ { print $2 }')"
echo "DEV_VERSION=$(./gradlew properties | awk '/^version:/ { print $2 }')" >> $GITHUB_ENV
echo "RELEASE_VERSION=$(./gradlew properties -Prelease | awk '/^version:/ { print $2 }')" >> $GITHUB_ENV
- name: Gradle build on ${{ matrix.java-version }}
if: matrix.os == 'ubuntu-latest'
run: |
Expand Down
40 changes: 0 additions & 40 deletions functional/FunctionalTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
import io.minio.Time;
import io.minio.UploadObjectArgs;
import io.minio.Xml;
import io.minio.credentials.AssumeRoleProvider;
import io.minio.errors.ErrorResponseException;
import io.minio.http.Method;
import io.minio.messages.AndOperator;
Expand Down Expand Up @@ -3638,40 +3637,6 @@ public static void deleteBucketReplication() throws Exception {
}
}

public static void assumeRoleProvider() throws Exception {
if (mintEnv) {
return;
}

String methodName = "credentialProvider(AssumeRoleProvider)";
System.out.println(methodName);
long startTime = System.currentTimeMillis();
try {
MinioClient client =
MinioClient.builder()
.endpoint("https://play.minio.io:9000")
.credentialsProvider(
new AssumeRoleProvider(
"https://play.minio.io:9000/",
"minio",
"minio123",
null,
null,
null,
null,
null,
null,
null))
.build();
String name = getRandomName();
client.makeBucket(MakeBucketArgs.builder().bucket(name).build());
client.removeBucket(RemoveBucketArgs.builder().bucket(name).build());
mintSuccessLog(methodName, null, startTime);
} catch (Exception e) {
handleException(methodName, null, startTime, e);
}
}

public static void runBucketTests() throws Exception {
makeBucket();
bucketExists();
Expand Down Expand Up @@ -3746,14 +3711,9 @@ public static void runObjectTests() throws Exception {
teardown();
}

public static void runCrdentialProviderTests() throws Exception {
assumeRoleProvider();
}

public static void runTests() throws Exception {
runBucketTests();
runObjectTests();
runCrdentialProviderTests();
}

public static boolean downloadMinio() throws IOException {
Expand Down

0 comments on commit cc93af1

Please sign in to comment.