address review comment

Signed-off-by: Bala.FA <[email protected]>
minio · Jul 6, 2021 · 7ba50a8 · 7ba50a8
1 parent f2a3b4d
commit 7ba50a8
Showing 1 changed file with 16 additions and 18 deletions.
diff --git a/api/src/main/java/io/minio/S3Base.java b/api/src/main/java/io/minio/S3Base.java
@@ -1098,6 +1098,18 @@ protected void populateResult()
     };
   }
 
+  private PartReader newPartReader(Object data, long objectSize, long partSize, int partCount) {
+    if (data instanceof RandomAccessFile) {
+      return new PartReader((RandomAccessFile) data, objectSize, partSize, partCount);
+    }
+
+    if (data instanceof InputStream) {
+      return new PartReader((InputStream) data, objectSize, partSize, partCount);
+    }
+
+    return null;
+  }
+
   /** Execute put object. */
   protected ObjectWriteResponse putObject(
       PutObjectBaseArgs args,
@@ -1116,12 +1128,8 @@ protected ObjectWriteResponse putObject(
     String uploadId = null;
     Part[] parts = null;
 
-    PartReader partReader = null;
-    if (data instanceof RandomAccessFile) {
-      partReader = new PartReader((RandomAccessFile) data, objectSize, partSize, partCount);
-    } else if (data instanceof InputStream) {
-      partReader = new PartReader((InputStream) data, objectSize, partSize, partCount);
-    } else {
+    PartReader partReader = newPartReader(data, objectSize, partSize, partCount);
+    if (partReader == null) {
       throw new IllegalArgumentException("data must be RandomAccessFile or InputStream");
     }
 
@@ -1959,12 +1967,7 @@ protected ObjectWriteResponse putObject(
           "data must be InputStream, RandomAccessFile, byte[] or String");
     }
 
-    PartReader partReader = null;
-    if (data instanceof RandomAccessFile) {
-      partReader = new PartReader((RandomAccessFile) data, length, length, 1);
-    } else if (data instanceof InputStream) {
-      partReader = new PartReader((InputStream) data, length, length, 1);
-    }
+    PartReader partReader = newPartReader(data, length, length, 1);
 
     if (partReader != null) {
       return putObject(
@@ -2212,12 +2215,7 @@ protected UploadPartResponse uploadPart(
           "data must be InputStream, RandomAccessFile, byte[] or String");
     }
 
-    PartReader partReader = null;
-    if (data instanceof RandomAccessFile) {
-      partReader = new PartReader((RandomAccessFile) data, length, length, 1);
-    } else if (data instanceof InputStream) {
-      partReader = new PartReader((InputStream) data, length, length, 1);
-    }
+    PartReader partReader = newPartReader(data, length, length, 1);
 
     if (partReader != null) {
       return uploadPart(