Cache the format of feeds #3126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoisin
force-pushed
the
cache_detection
branch
from
5ddb823 to
bd316a5
Compare
jvoisin
force-pushed
the
cache_detection
branch
from
bd316a5 to
84c3a16
Compare
jvoisin
force-pushed
the
cache_detection
branch
2 times, most recently
from
a729e9a to
22466eb
Compare
jvoisin
force-pushed
the
cache_detection
branch
2 times, most recently
from
4de54c3 to
1682327
Compare
Detecting the format of a feed accounts for up to 30% of the time spent in `parser.ParseFeed`. Cache the value once detected, as it'll never change.
jvoisin
force-pushed
the
cache_detection
branch
from
1682327 to
ebeae2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detecting the format of a feed accounts for up to 30% of the time spent in
parser.ParseFeed. Cache the value once detected, as it'll never change.This should close #2973