fix(greader): set CrawlTimeMsec at the correct precision #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Bestavros <[email protected]>
fguillot
reviewed
May 29, 2024
| @@ -1022,7 +1022,7 @@ func (h *handler) streamItemContentsHandler(w http.ResponseWriter, r *http.Reque | |||
| Title: entry.Title, | |||
| Author: entry.Author, | |||
| TimestampUsec: fmt.Sprintf("%d", entry.Date.UnixNano()/(int64(time.Microsecond)/int64(time.Nanosecond))), | |||
| CrawlTimeMsec: fmt.Sprintf("%d", entry.Date.UnixNano()/(int64(time.Microsecond)/int64(time.Nanosecond))), | |||
| CrawlTimeMsec: fmt.Sprintf("%d", entry.Date.UnixNano()/(int64(time.Millisecond)/int64(time.Nanosecond))), | |||
| Published: entry.Date.Unix(), | |||
| Updated: entry.Date.Unix(), | |||
There was a problem hiding this comment.
I'm wondering why it was implemented this way in the first place. It could probably be changed like this but I need to test first:
- TimestampUsec: fmt.Sprintf("%d", entry.Date.UnixNano()/(int64(time.Microsecond)/int64(time.Nanosecond))),
- CrawlTimeMsec: fmt.Sprintf("%d", entry.Date.UnixNano()/(int64(time.Microsecond)/int64(time.Nanosecond))),
+ TimestampUsec: fmt.Sprintf("%d", entry.Date.UnixMicro()),
+ CrawlTimeMsec: fmt.Sprintf("%d", entry.Date.UnixMilli()),
Published: entry.Date.Unix(),
- Updated: entry.Date.Unix(),
+ Updated: entry.ChangedAt.Unix(),There was a problem hiding this comment.
I have submitted PR #2673 with the diff mentioned above. I have tested with Reeder on iOS.
There was a problem hiding this comment.
@fguillot Thanks for the quick fix! I'll check how it works on Read You once it rolls out to the hosted service and try to remember to post an update here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you follow the guidelines?
This PR is a quick and simple fix for #2669, where you can find a full writeup. Resolves #2669.