After 2.1.0 upgrade, cannot open selected article by pressing Return key
#2366
Comments
|
The same is true when looking at categories. Previously I could select a bunch of feeds grouped by category by pressing |
|
Understood. From the pull request it's clear that this was a conscious decision. The way I understood it, is that the I have no idea if anyone besides me might want that, but here are my arguments.
I can take a look if this can easily be implemented and especially if it doesn't cause any hidden problems. I guess we'd want to keep |
|
I think it's good and reasonable to bring back this behavior, pressing the |
There are a few things that need to be done, to make this work. First, we need to register `Enter` as another hotkey that opens the selected item. However, by default the `KeyboardHandler` will override all default actions. That might make sense for any other key, but for the `Enter` key, we want to keep the default behavior (i.e. follow a selected link or press a button). So for this single key event, we do not call `preventDefault()`. I see this as unproblematic for the following reasons. 1. With the changes from #2348, when we're in a list of items (articles, categories, feeds), there is no link selected. This is what made the `Enter` key work _implicitly_ in the past. With nothing selected, the `Enter` key will do nothing by default. 2. If we have **any** link selected (including when we are in a view with a list of selectable items), we'll get the default action of `Enter` (i.e. follow a link), which is exactly what we had before. Lastly, we need to update the list of keyboard shortcuts displayed when pressing `?`. This fixes #2366.
There are a few things that need to be done, to make this work. First, we need to register `Enter` as another hotkey that opens the selected item. However, by default the `KeyboardHandler` will override all default actions. That might make sense for any other key, but for the `Enter` key, we want to keep the default behavior (i.e. follow a selected link or press a button). So for this single key event, we do not call `preventDefault()`. I see this as unproblematic for the following reasons. 1. With the changes from miniflux#2348, when we're in a list of items (articles, categories, feeds), there is no link selected. This is what made the `Enter` key work _implicitly_ in the past. With nothing selected, the `Enter` key will do nothing by default. 2. If we have **any** link selected (including when we are in a view with a list of selectable items), we'll get the default action of `Enter` (i.e. follow a link), which is exactly what we had before. Lastly, we need to update the list of keyboard shortcuts displayed when pressing `?`. This fixes miniflux#2366.
hello,
discovered another difference when using Miniflux with the keyboard.
Previously I could open a selected article by pressing the
Returnkey. Now this doesn't work anymore. The keyostill works, as per documentation.I assume this is an effect of
<div class="items">having lost the propertydir=auto, correct?I would not strictly call this a bug because it was not documented, perhaps more a XKCD 1172 situation 🙂 but it would be nice to have it back
The text was updated successfully, but these errors were encountered: