Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete statement for rule_type_data_sources. #5097

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Nov 29, 2024

Summary

This statement is necessary to allow updates on Rule Types. Since an update does not modify the ID, we can't expect cascading deletes to happen, and thus have to perform the cleanup manually.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Autogenerated code.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This statement is necessary to allow updates on Rule Types. Since an
update does not modify the ID, we can't expect cascading deletes to
happen, and thus have to perform the cleanup manually.
@blkt blkt self-assigned this Nov 29, 2024
@blkt blkt requested a review from a team as a code owner November 29, 2024 15:07
@coveralls
Copy link

Coverage Status

coverage: 55.149% (+0.007%) from 55.142%
when pulling 50ce07f on chore/add-delete-statement-for-rule-type-data-sources
into 93c054a on main.

@JAORMX JAORMX merged commit 1bb8571 into main Dec 2, 2024
26 checks passed
@JAORMX JAORMX deleted the chore/add-delete-statement-for-rule-type-data-sources branch December 2, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants