Fix properties update validation #4980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The properties validation was validating the envelope instead of the actual properties. This lead to issues of us not being able to accurately update required fields, even if this was allowed by previous checks. Signed-off-by: Juan Antonio Osorio <[email protected]>
rdimitrov
reviewed
Nov 15, 2024
| @@ -119,7 +135,7 @@ func validateProperties(oldSchemaMap, newSchemaMap map[string]any) error { | |||
|
|
|||
| // The new schema should be a superset of the old schema | |||
| // if it's not, we may break profiles using this rule type | |||
| if !cmp.Equal(newSchemaMap, castedDst, opts...) { | |||
| if !cmp.Equal(newPropertiesMap, castedDst, opts...) { | |||
There was a problem hiding this comment.
hey, do I read this correct that castedDst comes from dst which comes from newPropertiesMap? If so, perhaps the comment on top might not be valid
rdimitrov
reviewed
Nov 15, 2024
| return fmt.Errorf("invalid new properties field") | ||
| } | ||
|
|
||
| dst, err := deepcopy.Anything(newPropertiesMap) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to deepcopy old schema: %v", err) |
Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
fix-properties-validate
branch
from
827010f to
aa0f09d
Compare
rdimitrov
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The properties validation was validating the envelope instead of the
actual properties. This lead to issues of us not being able to
accurately update required fields, even if this was allowed by previous
checks.
By fixing this, we now have better validation and updates are no longer an issue for rule types.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: