Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the embedded secret_scanning ruletype used in quickstart #4946

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

rdimitrov
Copy link
Member

Summary

The following PR updates the embedded secret_scanning ruletype used in quickstart.

Eventually we may want to update the command and reuse the already existing stacklok prefixed ruletype.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov requested a review from a team as a code owner November 12, 2024 11:16
@coveralls
Copy link

coveralls commented Nov 12, 2024

Coverage Status

coverage: 54.762% (-0.003%) from 54.765%
when pulling 8583933 on fix-quick
into 0c76dba on main.

JAORMX
JAORMX previously approved these changes Nov 12, 2024
@rdimitrov rdimitrov merged commit 5d71aaa into main Nov 12, 2024
23 checks passed
@rdimitrov rdimitrov deleted the fix-quick branch November 12, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants