Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for jq eval type #4919

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Nov 8, 2024

Summary

This adds validation on the type object, so we can check if the jq eval
invocation is valid before the rule type is persisted in the db.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This adds validation on the type object, so we can check if the jq eval
invocation is valid before the rule type is persisted in the db.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from a team as a code owner November 8, 2024 13:29
@coveralls
Copy link

coveralls commented Nov 8, 2024

Coverage Status

coverage: 54.751% (-0.01%) from 54.761%
when pulling 58c20f9 on JAORMX:jq-validation
into 9dbe050 on mindersec:main.

@JAORMX JAORMX merged commit 8b01055 into mindersec:main Nov 8, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants