Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type from trusty-sdk-go. #4917

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix type from trusty-sdk-go. #4917

merged 1 commit into from
Nov 8, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Nov 8, 2024

Summary

This makes explicit use of a type from Trusty SDK library instead of a hand-rolled one which made migrating files around the SDK library itself harder.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Unit tested.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This makes explicit use of a type from Trusty SDK library instead of a
hand-rolled one which made migrating files around the SDK library
itself harder.
@blkt blkt self-assigned this Nov 8, 2024
@blkt blkt requested a review from a team as a code owner November 8, 2024 12:41
@coveralls
Copy link

Coverage Status

coverage: 54.77% (+0.007%) from 54.763%
when pulling 78c54c5 on fix/fix-type-in-trusty-tests
into b96d791 on main.

@blkt blkt merged commit 9195268 into main Nov 8, 2024
26 checks passed
@blkt blkt deleted the fix/fix-type-in-trusty-tests branch November 8, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants