Add proto validation for Projects #4909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2317,7 +2317,14 @@ message UpdateProjectRequest { | |||
| ]; | |||
|
|
|||
| // description is the description of the project to update. | |||
There was a problem hiding this comment.
This is uninterpreted text, right (not Markdown)?
There was a problem hiding this comment.
Yes, also confirmed it with Giuseppe 👍
| @@ -2336,7 +2343,14 @@ message ProjectPatch { | |||
| ]; | |||
|
|
|||
| // description is the description of the project to update. | |||
proto/minder/v1/minder.proto
Outdated
| string description = 3 [ | ||
| (buf.validate.field).string = { | ||
| pattern: "[[:space:][:punct:][:word:]]*", | ||
| min_len: 1, |
There was a problem hiding this comment.
If min_len is 0, you don't need the ignore annotation.
| // subject is the subject to which the role is assigned. | ||
| string subject = 2; | ||
| string subject = 2 [ | ||
| (buf.validate.field).string = {uuid: true}, |
There was a problem hiding this comment.
I'm not sure these are always UUIDs, but they may happen to be UUIDs for now. I think it's okay to leave this as-is at the moment.
Signed-off-by: Radoslav Dimitrov <[email protected]>
Signed-off-by: Radoslav Dimitrov <[email protected]>
rdimitrov
force-pushed
the
validate-projects
branch
from
aea725f to
7bf7e26
Compare
evankanderson
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref https://github.com/stacklok/minder-stories/issues/94
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: