Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diff full ingester double deref. #4732

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Oct 11, 2024

Summary

This was causing errors during evaluations of rules that cast res.Object like
https://github.com/stacklok/minder/blob/main/internal/engine/eval/homoglyphs/application/homoglyphs_service.go#L84

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Oct 11, 2024
@coveralls
Copy link

Coverage Status

coverage: 53.118% (-0.007%) from 53.125%
when pulling 36c526e on fix/diff-full-ingester-double-deref
into f191f5d on main.

@rdimitrov rdimitrov merged commit db959ef into main Oct 11, 2024
21 checks passed
@rdimitrov rdimitrov deleted the fix/diff-full-ingester-double-deref branch October 11, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants