Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add template mapping functions #4714

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Oct 10, 2024

Summary

These are handy to deal with properties in protobufs within minder's
templates.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

These are handy to deal with properties in protobufs within minder's
templates.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@coveralls
Copy link

coveralls commented Oct 10, 2024

Coverage Status

coverage: 53.378% (+0.06%) from 53.315%
when pulling a734d76 on JAORMX:template-mapper
into 6c76fa4 on stacklok:main.

@JAORMX JAORMX requested review from blkt, jhrozek and Vyom-Yadav October 10, 2024 10:49
@JAORMX JAORMX merged commit a4d5c7f into mindersec:main Oct 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants