Allow customizing AckDeadline to allow for long-running sets of retries #4549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It turns out that Watermill SQL maintains an internal timeout on message delivery, and retries messages which take longer than the timeout. On one hand, this feels like good infrastructure practice, but it interferes with related Watermill middleware for retries and handling poison messages. One example of this is
AckDeadline
:Fixes #4483
Change Type
Mark the type of change your PR introduces:
Testing
Manual testing with https://github.com/eleftherias/msg-queue-repro.git to find the issue and controlling setting, and then starting Minder to check that the new setting was accepted. I did not build a unit test with a timeout to verify this setting, but did test manually in the reproduction repo.
Review Checklist: