Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong indentation of HTML in PR comments. #4531

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Sep 18, 2024

Summary

Some trailing </details> tag in trusty PR comments were misplaced because they were missing a \n before them, causing the dependency list to be a tree instead.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Some trailing `</details>` tag in trusty PR comments were misplaced
because they were missing a `\n` before them, causing the dependency
list to be a tree instead.
@blkt blkt self-assigned this Sep 18, 2024
@blkt blkt merged commit 01a8bea into main Sep 18, 2024
21 checks passed
@blkt blkt deleted the fix/trusty_engine_pr_comment_newlines branch September 18, 2024 14:17
@coveralls
Copy link

Coverage Status

coverage: 52.843% (+0.004%) from 52.839%
when pulling 8cb0e81 on fix/trusty_engine_pr_comment_newlines
into fabeea9 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants