Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make max number of idle connections configurable. #4527

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Sep 18, 2024

Summary

This change allows setting the maximum number of idle connections via configuration file. This is useful since local testing showed that Minder eventer spends roughly ~25% of its time opening connections to Postgres.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Checked via pprof and debugger.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This change allows setting the maximum number of idle connections via
configuration file. This is useful since local testing showed that
Minder `eventer` spends roughly ~25% of its time opening connections
to Postgres.
@blkt blkt self-assigned this Sep 18, 2024
@coveralls
Copy link

Coverage Status

coverage: 52.843% (+0.002%) from 52.841%
when pulling 909d10c on enh/make-idle-connections-configurable
into 9054b74 on main.

@blkt blkt merged commit 62eccf6 into main Sep 19, 2024
22 checks passed
@blkt blkt deleted the enh/make-idle-connections-configurable branch September 19, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants