Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ancillary indexes to improve deletion. #4508

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Sep 17, 2024

Summary

Provider deletion, or entity deletion in general, runs into performance problems without this indexes as two triggers for constraint were executing full table scans on pretty crowded tables.

These two indexes solve that problem.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Tested in sandbox.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Provider deletion, or entity deletion in general, runs into
performance problems without this indexes as two triggers for
constraint were executing full table scans on pretty crowded tables.

These two indexes solve that problem.
@blkt blkt self-assigned this Sep 17, 2024
@blkt blkt merged commit cf38df6 into main Sep 17, 2024
22 checks passed
@blkt blkt deleted the fix/evaluation-id-indexes-migration branch September 17, 2024 12:19
@coveralls
Copy link

Coverage Status

coverage: 52.735% (-0.004%) from 52.739%
when pulling d315c79 on fix/evaluation-id-indexes-migration
into ac573e7 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants