Implement getting entity name for gitlab provider #4430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrozek
reviewed
Sep 10, 2024
| @@ -210,6 +210,15 @@ type newPropertiesConfig struct { | |||
| skipPrefixCheck bool | |||
| } | |||
|
|
|||
| // MustNewProperties creates Properties from a map or panics | |||
| func MustNewProperties(props map[string]any, opts ...newPropertiesOption) *Properties { | |||
There was a problem hiding this comment.
not against adding this to the properties module, but would it suffice to have the method in the tests?
There was a problem hiding this comment.
I'm not able to import from a _test.go file. I moved this where it's used.
jhrozek
reviewed
Sep 10, 2024
jhrozek
previously approved these changes
Sep 10, 2024
This adds a simple implementation of getting the name for an entity based on given properties. This also introduces the first properties for the GitLab provider, which are the group and project. Related-To: #4331 Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
gitlab-entityname
branch
from
c6b69c5 to
169537e
Compare
jhrozek
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a simple implementation of getting the name for an entity
based on given properties. This also introduces the first properties for
the GitLab provider, which are the group and project.
Related-To: #4331
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: