Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use central entity tables to list remote repos #4429

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Use central entity tables to list remote repos #4429

merged 1 commit into from
Sep 12, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Sep 10, 2024 •
edited
Loading

Summary

This is part of generalizing entity registration, as other providers
will need to work with this mechanism. As part of the migration, this
moved the logic to use our new entity model.

Related-To: #4331
Closes: #4420

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from jhrozek September 10, 2024 12:04
@JAORMX JAORMX force-pushed the entities-remotelist branch from d4fcf06 to f084153 Compare September 10, 2024 12:05
@JAORMX JAORMX mentioned this pull request Sep 10, 2024
Closed
@coveralls
Copy link

coveralls commented Sep 10, 2024 •
edited
Loading

Coverage Status

coverage: 53.457% (-0.04%) from 53.495%
when pulling cc5e95a on entities-remotelist
into 4c9fd0a on main.

jhrozek
jhrozek previously approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with two suggestions

@JAORMX JAORMX force-pushed the entities-remotelist branch from f084153 to b8e24bd Compare September 11, 2024 08:02
@JAORMX JAORMX marked this pull request as draft September 11, 2024 13:34
@JAORMX JAORMX force-pushed the entities-remotelist branch from b8e24bd to 344bcbd Compare September 12, 2024 05:56
@JAORMX JAORMX marked this pull request as ready for review September 12, 2024 06:03
@JAORMX
Use central entity tables to list remote repos
cc5e95a 
This is part of generalizing entity registration, as other providers
will need to work with this mechanism. As part of the migration, this
moved the logic to use our new entity model.

Related-To: #4331
Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX force-pushed the entities-remotelist branch from 344bcbd to cc5e95a Compare September 12, 2024 07:06
@JAORMX JAORMX merged commit ab5af43 into main Sep 12, 2024
22 checks passed
@JAORMX JAORMX deleted the entities-remotelist branch September 12, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdimitrov rdimitrov rdimitrov approved these changes

@jhrozek jhrozek Awaiting requested review from jhrozek

@blkt blkt Awaiting requested review from blkt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unused GetEntitiesByType SQL statement
4 participants
@JAORMX @coveralls @jhrozek @rdimitrov