Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch by upstream ID in property service #4412

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fetch by upstream ID in property service #4412

merged 1 commit into from
Sep 10, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Sep 10, 2024

Summary

This allows the property service to also attempt searching by upstream
ID when trying to retrive properties.

Related-To: #4331

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX force-pushed the fetch-by-upstreamid branch from 74a007b to 1b670c7 Compare September 10, 2024 07:17
@coveralls
Copy link

coveralls commented Sep 10, 2024

Coverage Status

coverage: 53.274% (+0.03%) from 53.241%
when pulling 1b670c7 on fetch-by-upstreamid
into 44d1523 on main.

This allows the property service to also attempt searching by upstream
ID when trying to retrive properties.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX force-pushed the fetch-by-upstreamid branch from 1b670c7 to 7bbc8af Compare September 10, 2024 08:56
@JAORMX JAORMX merged commit da2aa91 into main Sep 10, 2024
21 checks passed
@JAORMX JAORMX deleted the fetch-by-upstreamid branch September 10, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants