Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix golangci-lint warnings #4408

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

evankanderson
Copy link
Member

Summary

Fix errors like https://github.com/stacklok/minder/actions/runs/10780415122/job/29912980252?pr=4382

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Read the errors and fixed them.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@coveralls
Copy link

coveralls commented Sep 10, 2024

Coverage Status

coverage: 53.239% (-0.002%) from 53.241%
when pulling 257e440 on evankanderson:fix-lint-errors
into 44d1523 on stacklok:main.

@@ -18,12 +18,12 @@ package properties

import (
"fmt"
"iter"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this was the old linter not recognizing iter as being from the go stdlib..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the nolint so we unblock main

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran make bootstrap to get the newer version of the linter.

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slap a nolint on TestEventer so we can merge :-) who cares about cyclomatic complexity on test functions.

@JAORMX JAORMX merged commit 5b199f0 into mindersec:main Sep 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants