Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch and store the language property #4403

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Sep 9, 2024

Summary

Since we already can get the language property in the REST call to get
most of the properties, we might as well store it as a property in the
database and let it be usable in selectors.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

I really need to add automated smoke tests for the selectors, but for now I have used:

selector: repository.properties['github/primary_language'] == 'Go'

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Since we already can get the language property in the REST call to get
most of the properties, we might as well store it as a property in the
database and let it be usable in selectors.
@jhrozek jhrozek merged commit 17cff48 into mindersec:main Sep 9, 2024
22 checks passed
@coveralls
Copy link

Coverage Status

coverage: 53.722% (-0.006%) from 53.728%
when pulling 09ff2ca on jhrozek:single_language_prop
into 7f9febe on stacklok:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants