Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report line numbers in log messages. #4402

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Sep 9, 2024

Summary

We don't print log lines, yet go requires a fair amount of code duplication, making it harder to find the impacted code.

This change configures the logger to always log line numbers in log messages.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Sep 9, 2024
We don't print log lines, yet go requires a fair amount of code
duplication, making it harder to find the impacted code.

This change configures the logger to always log line numbers in log
messages.
@blkt blkt force-pushed the enh/log-line-numbers-like-we-are-in-the-2ks branch from 5c72a2c to 0e63be5 Compare September 9, 2024 09:38
@dmjb
Copy link
Contributor

dmjb commented Sep 9, 2024

❤️

@blkt blkt merged commit 0206ab7 into main Sep 9, 2024
21 checks passed
@blkt blkt deleted the enh/log-line-numbers-like-we-are-in-the-2ks branch September 9, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants