Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore sql.ErrNoRows for GetRepositoryByRepoID #4389

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Sep 6, 2024

Summary

We saw these in the minder cloud staging logs as well

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

N/A

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

We saw these in the minder cloud staging logs as well
@coveralls
Copy link

Coverage Status

coverage: 53.648% (+0.001%) from 53.647%
when pulling 2b6de30 on jhrozek:delete_repo_err
into 1f9c1ef on stacklok:main.

@JAORMX JAORMX merged commit 6f699dc into mindersec:main Sep 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants