Ignore sql.ErrNoRows on deleting repos by ID #4387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've seen this in minder cloud staging:
```
587a40169630","topic":"internal.entity.delete.event","handler":"github.com/stacklok/minder/internal/reconcilers.(*Reconciler).handleEntityDeleteEvent-fm-internal.entity.delete.event","component":"eventer","Timestamp":1725611382257727611,"message":"Found
error handling message"}
{"level":"error","component":"watermill","exception.message":"error
deleting repository from DB: error retrieving repository
e0e9fdde-bb2d-4a1d-9e0f-b8f5c006b42a in project
a5d7a1e4-f6a9-4282-8cc6-1a0e1613d1ae: sql: no rows in result
set","retry_no":3,"max_retries":3,"wait_time":0,"elapsed_time":105398463,"Timestamp":1725611382257739431,"message":"Error
occurred, retrying"}
```
blkt
approved these changes
Sep 6, 2024
| return fmt.Errorf("error deleting repository from DB: %w", err) | ||
| err := r.repos.DeleteByID(ctx, event.EntityID, event.ProjectID) | ||
| if errors.Is(err, sql.ErrNoRows) { | ||
| return nil |
There was a problem hiding this comment.
nit: This codepath only flows from webhook events, right? I would at least add a log message, I find it weird that we try to delete by ID something that does not exist anymore.
There was a problem hiding this comment.
I'll fix this in a follow-up where I ignore another such error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We've seen this in minder cloud staging:
Change Type
Testing
added a unit test
Review Checklist: