-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial MAINTAINERS document #4382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One formatting issue, and one minor nit on verbiage, but I actually wonder if this is a broader question about whether we expect this document to be rather evergreen or something that we revisit regularly? My experience is that these sorts of things often don't get updated as frequently, so something like:
Note: many project documents are currently in the Stacklok Google Drive instance. We are working to open the relevant documents for community review and feedback
Has a tendency to bitrot. I typically set the expectations that we should hold ourselves to in a document like this and then point out where we fail to do that in more dynamic / less static areas (issues, etc). But this is just my $0.02 from failing to update these sorts of docs as time changes.
MAINTAINERS.md
Outdated
Assignment of permissions for these maintainers is currently managed by Stacklok | ||
as a matter of accident; changes to this list will need a Stacker to apply some | ||
private automation to grant the privileges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This para reads a little clunky to me; the automation is intentional isn't it? It doesn't feel like something we need to explain away. Maybe "because it's managed by automation" or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The automation is intentional, the fact that the automation is only available to Stackers because it's tied in with our general administration of https://github.com/stacklok/*
, and we don't intend to open-source everything underneath that directory.
I expect us to revisit this document when we and a foundation perform due diligence on the donation of Minder to said foundation. |
Summary
Define a maintainership process for external contributors for Minder, including initial maintainer list (currently all Stackers).
Change Type
Mark the type of change your PR introduces:
Testing
N/A
Review Checklist: