Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Belatedly address several review comments of my earlier PRs #4381

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Sep 5, 2024

Summary

We merged PRs to avoid blocking other work while the PRs still had some comments pending. This PR addresses them.

  • Use named return values in parseArtifactName
  • Add unit tests for artifact property handling
  • Move WithSkipPrefixCheckTestOnly to tests

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

make test

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the added coverage, thank you!

@coveralls
Copy link

Coverage Status

coverage: 53.133% (+0.3%) from 52.863%
when pulling 7343460 on jhrozek:review_comments
into b496555 on stacklok:main.

@jhrozek jhrozek merged commit 3cdde9b into mindersec:main Sep 6, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants