Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pre-create github provider on registration #4367

Merged

Conversation

psekar
Copy link
Contributor

@psekar psekar commented Sep 5, 2024

Summary

On the first user registration, a provider entry is created in the database. Although, the provider cannot be used to register repos due to the lack of credential. As part of this change, the default provider will not be created and user will continue with provider enroll step.

Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.

Fixes #(related issue)
#4213

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

After the first user login, verify the provider list returns empty. Continue with provider enrollment and repo registration should successfully complete.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@psekar psekar changed the title donot create provider during first user registration Don't pre-create github provider on registration Sep 5, 2024
@coveralls
Copy link

coveralls commented Sep 5, 2024

Coverage Status

coverage: 53.646% (-0.007%) from 53.653%
when pulling a9fb173 on tinytrail:user-registration-donotcreate-provider
into bec2b46 on stacklok:main.

@eleftherias eleftherias self-assigned this Sep 5, 2024
@psekar psekar force-pushed the user-registration-donotcreate-provider branch 2 times, most recently from 2e1e6d9 to 265ba4c Compare September 6, 2024 17:30
@psekar psekar force-pushed the user-registration-donotcreate-provider branch from ffbd143 to e9c8643 Compare September 6, 2024 18:34
@eleftherias
Copy link
Contributor

Thank you for your contribution @psekar!

note: The failing coverage step is because of one of our flaky tests (we're looking into it), not related to your changes.

@eleftherias eleftherias merged commit 0110c12 into mindersec:main Sep 9, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants