Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve errors returned by history list endpoint. #4359

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Improve errors returned by history list endpoint. #4359

merged 1 commit into from
Sep 4, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Sep 4, 2024

Summary

We were not returning user visible errors, making it hard for the user to understand what was wrong with the input.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manual tests.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Sep 4, 2024
@blkt blkt force-pushed the enh/history-list-better-user-visible-errors branch from b1473a5 to 492dd74 Compare September 4, 2024 08:57
@blkt blkt requested a review from JAORMX September 4, 2024 08:57
JAORMX
JAORMX approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@JAORMX JAORMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@coveralls
Copy link

coveralls commented Sep 4, 2024 •
edited
Loading

Coverage Status

coverage: 53.031% (-0.01%) from 53.044%
when pulling 492dd74 on enh/history-list-better-user-visible-errors
into cc46e40 on main.

@blkt blkt merged commit cca944e into main Sep 4, 2024
21 checks passed
@blkt blkt deleted the enh/history-list-better-user-visible-errors branch September 4, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JAORMX JAORMX JAORMX approved these changes

Assignees

@blkt blkt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blkt @coveralls @JAORMX