Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test code from..tests. #4313

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Aug 29, 2024

Summary

I instrumented one of the tests to inject a lot of entries to measure DB
query performance. I then promptly submitted the code without removing
it.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

make test

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

I instrumented one of the tests to inject a lot of entries to measure DB
query performance. I then promptly submitted the code without removing
it.
@JAORMX JAORMX merged commit e0376fe into mindersec:main Aug 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants