Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show can_remediate: false for the ruletype cli commands #4291

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Aug 27, 2024

Summary

The following PR shows the can_remediate: false property in the ruletype list, apply and create tables. The table from ruletype get is different (row based) and we already show Remediate: unsupported. This is shown in case the ruletype has an empty/null Remediation field in its Def section (which in practice means no remediation support).

Fixes #4240

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@rdimitrov rdimitrov changed the title Show can_remediate: false for the ruletype list cli command Show can_remediate: false for the ruletype cli commands Aug 27, 2024
@coveralls
Copy link

Coverage Status

coverage: 53.865% (-0.004%) from 53.869%
when pulling 7a64f6d on show-no-remediation
into 405ea41 on main.

@rdimitrov rdimitrov merged commit 594e526 into main Aug 28, 2024
24 checks passed
@rdimitrov rdimitrov deleted the show-no-remediation branch August 28, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants