Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint: Add HTTP URL and Method to HTTP/REST ingester #4289

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Aug 27, 2024

Summary

This adds the URL and HTTP method to the checkpoint information. This is
handy to know what path, method and even API version was used at a given
time when evaluating an entity.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested review from blkt and jhrozek August 27, 2024 11:16
@coveralls
Copy link

coveralls commented Aug 27, 2024

Coverage Status

coverage: 53.865% (+0.001%) from 53.864%
when pulling 54f24bf on http-checkpoint
into ef2b9db on main.

This adds the URL and HTTP method to the checkpoint information. This is
handy to know what path, method and even API version was used at a given
time when evaluating an entity.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX merged commit 405ea41 into main Aug 27, 2024
21 checks passed
@JAORMX JAORMX deleted the http-checkpoint branch August 27, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants