Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EEA: Rely solely on entity instances table #4287

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Aug 27, 2024

Summary

This removes the usage of the per-entity tables from the EEA queries to
rely solely on the entity instances table. A further PR will remove the
columsn from that table.

Related-to: #4169

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested review from blkt, jhrozek and rdimitrov August 27, 2024 10:38
@coveralls
Copy link

coveralls commented Aug 27, 2024

Coverage Status

coverage: 53.862% (-0.007%) from 53.869%
when pulling e73a03a on rm-entities-queries-eea
into 405ea41 on main.

@JAORMX JAORMX force-pushed the rm-entities-queries-eea branch from 40d4291 to db75894 Compare August 27, 2024 12:25
@JAORMX JAORMX requested a review from eleftherias August 28, 2024 05:40
This removes the usage of the per-entity tables from the EEA queries to
rely solely on the entity instances table. A further PR will remove the
columsn from that table.

Related-to: #4169

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX force-pushed the rm-entities-queries-eea branch from db75894 to e73a03a Compare August 28, 2024 05:41
@JAORMX JAORMX requested a review from dmjb August 28, 2024 05:46
@JAORMX JAORMX merged commit 345b8e8 into main Aug 28, 2024
21 checks passed
@JAORMX JAORMX deleted the rm-entities-queries-eea branch August 28, 2024 07:20
JAORMX added a commit that referenced this pull request Aug 28, 2024
JAORMX added a commit that referenced this pull request Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants