Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Provider's FetchProperty/FetchAllProperties interface methods to look up by Properties, not just a name #4266

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Aug 23, 2024

Summary

The initial implementation of the FetchProperty/FetchAllProperties
methods was very github specific in the sense that it only allowed
looking up the entity by name. Other providers might not have a name and
the provider is best equipped to know what to look by.

Let's send Properties instead and let the provider pick the right ones
or return an error.

Related: #4171

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

repo register + unit tests

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

…ods to look up by Properties, not just a name

The initial implementation of the `FetchProperty/FetchAllProperties`
methods was very github specific in the sense that it only allowed
looking up the entity by name. Other providers might not have a name and
the provider is best equipped to know what to look by.

Let's send Properties instead and let the provider pick the right ones
or return an error.

Related: mindersec#4171
@coveralls
Copy link

Coverage Status

coverage: 53.692% (-0.01%) from 53.703%
when pulling c3b6967 on jhrozek:property_fetch_change_signature
into 02ab8b0 on stacklok:main.

@jhrozek jhrozek merged commit 5374b0e into mindersec:main Aug 26, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants