Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a ruletype state field in the minder proto #4261

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

rdimitrov
Copy link
Member

Summary

The following PR introduces a new field to the ruletype proto message called state.

It also includes a custom marshal/unmarshal handling so we fail if we try to unmarshal the field with a value that is not one of the enums.

Fixes #4241

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@coveralls
Copy link

coveralls commented Aug 23, 2024

Coverage Status

coverage: 53.707% (+0.004%) from 53.703%
when pulling 07ba011 on add-state
into 0cbe5ab on main.

@rdimitrov
Copy link
Member Author

Ran the smoke tests locally using the PR from - https://github.com/stacklok/minder-rules-and-profiles/pull/145 and they passed.

Signed-off-by: Radoslav Dimitrov <[email protected]>
@rdimitrov rdimitrov merged commit 21e0927 into main Aug 23, 2024
22 checks passed
@rdimitrov rdimitrov deleted the add-state branch August 23, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the protobuf definition of the ruletype message to support the new state field
3 participants