Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetEntityByName must accept the type, too #4260

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Aug 23, 2024

Summary

Our database getter wouldn't handle the case where different entities
have the same name. Let's add the entity type as a parameter for the
getter.

Related: #4171

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

make test + part of a larger branch

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Our database getter wouldn't handle the case where different entities
have the same name. Let's add the entity type as a parameter for the
getter.

Related: mindersec#4171
@JAORMX JAORMX merged commit 0cbe5ab into mindersec:main Aug 23, 2024
21 checks passed
@coveralls
Copy link

Coverage Status

coverage: 53.715% (+0.01%) from 53.703%
when pulling 41d9e68 on jhrozek:prop_get_by_name_ent_type
into 2b9c305 on stacklok:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants