Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Iterator over Properties #4254

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Add an Iterator over Properties #4254

merged 1 commit into from
Aug 23, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Aug 22, 2024

Summary

Uses the new Go 1.23 feature to implement an iterator over properties.
This will simplify the future code.

Related: #4171

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

part of a larger branch

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

JAORMX
JAORMX previously approved these changes Aug 23, 2024
@coveralls
Copy link

Coverage Status

coverage: 53.738% (+0.02%) from 53.716%
when pulling 97ea006 on jhrozek:prop_iter
into b30ca2e on stacklok:main.

Uses the new Go 1.23 feature to implement an iterator over properties.
This will simplify the future code.

Related: mindersec#4171
@jhrozek jhrozek merged commit 39b3a88 into mindersec:main Aug 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants