Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release_phase column to rule_type table. #4249

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Add release_phase column to rule_type table. #4249

merged 1 commit into from
Aug 23, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Aug 22, 2024

Summary

The new release_phase column of rule_type table contains release phase information about the rule type, being one of alpha, beta, ga, or deprecated. The available states are defined as an enumerated type.

Fixes #4242
Fixes #4243

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Manually tested up and down migration.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@blkt blkt self-assigned this Aug 22, 2024
@blkt blkt requested a review from a team as a code owner August 22, 2024 10:52
@coveralls
Copy link

coveralls commented Aug 22, 2024

Coverage Status

coverage: 53.703% (-0.008%) from 53.711%
when pulling 8d9659e on issue-4242
into 21e0927 on main.

@rdimitrov
Copy link
Member

@blkt - it seems there are some issues making the checks fail

dmjb
dmjb previously approved these changes Aug 22, 2024
@JAORMX
Copy link
Contributor

JAORMX commented Aug 23, 2024

uhm... Are states anything that would be acted on? Why not have a labeling system or annotations instead?

@blkt blkt force-pushed the issue-4242 branch 3 times, most recently from fbba9b9 to be1eb5c Compare August 23, 2024 14:24
The new `release_phase` column of `rule_type` table contains release
phase information about the rule type, being one of `alpha`, `beta`,
`ga`, or `deprecated`. The available states are defined as an
enumerated type.

Fixes #4242
Fixes #4243
@blkt blkt changed the title Add state column to rule_type table. Add release_phase column to rule_type table. Aug 23, 2024
@rdimitrov rdimitrov merged commit 02ab8b0 into main Aug 23, 2024
24 checks passed
@rdimitrov rdimitrov deleted the issue-4242 branch August 23, 2024 14:38
@evankanderson
Copy link
Member

Question: do we want to hard-code this metadata in the database schema, or store in a flexible envelope (like JSON)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants