Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ruletype test token's viper path unique #4236

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Make ruletype test token's viper path unique #4236

merged 1 commit into from
Aug 22, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Aug 22, 2024

Summary

This is needed for it to work... as it seems the viper name has clashed
with other subcommands in that binary.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This is needed for it to work... as it seems the viper name has clashed
with other subcommands in that binary.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from a team as a code owner August 22, 2024 06:03
@coveralls
Copy link

Coverage Status

coverage: 53.751% (-0.008%) from 53.759%
when pulling 4d85377 on rule-type-token
into 3c3cf63 on main.

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I was always using AUTH_TOKEN=blah ruletype test without issues. What was is that was not working?

@JAORMX
Copy link
Contributor Author

JAORMX commented Aug 22, 2024

Interesting, I was always using AUTH_TOKEN=blah ruletype test without issues. What was is that was not working?

that's weird, I also tried that this morning and it did not work 😕

@JAORMX JAORMX merged commit d32c80c into main Aug 22, 2024
22 checks passed
@rdimitrov
Copy link
Member

I saw @jhrozek's comment but acked it in case what he suggested doesn't work for you so you have to merge it anyway

@JAORMX JAORMX deleted the rule-type-token branch August 22, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants