Split ProfileService proto to ProfileService and RuleTypeService #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm weirdly coverage is failing because it can't find the command. |
JAORMX
reviewed
Aug 22, 2024
There was a problem hiding this comment.
The change LGTM, can you also add the new service to the following list https://github.com/stacklok/minder/blob/main/deployment/helm/templates/ingress.yaml#L28 so the ingress takes it into use?
|
@JAORMX Yep sure thing, just pushed the change up, let me know if there's anything else 👍 |
ChrisJBurns
force-pushed
the
split-profile-rule-type-service
branch
from
f385e68 to
febe7fd
Compare
|
LGTM! I'll merge this on Monday |
|
@JAORMX Let me know before you do and I can make sure the branch is rebased with |
JAORMX
previously approved these changes
Aug 27, 2024
|
@ChrisJBurns can you rebase? Sorry, Monday was a little hectic. |
The `ProfileService` has methods for both profile and rule types, we want to split them so we can keep relevant methods together. Also added a RuleTypeService Ingress entrypoint Signed-off-by: ChrisJBurns <[email protected]>
rdimitrov
force-pushed
the
split-profile-rule-type-service
branch
from
febe7fd to
cb4e600
Compare
|
@ChrisJBurns - hey, I went ahead and rebased the PR against main, hope you don't mind 😃 |
|
@rdimitrov Nope, not at all, you beat me to it! 😄 |
blkt
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the
ProfileServicehas methods for both profile and rule types, we want to split them so we can keep the relevant methods together.Fixes #2118
Change Type
Testing
N/A
Review Checklist: