Use central entities table for EEA logic #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
force-pushed
the
eea-entity-instance-move
branch
from
a7cd840 to
e53933e
Compare
jhrozek
previously approved these changes
Aug 21, 2024
JAORMX
force-pushed
the
eea-entity-instance-move
branch
from
e53933e to
f57b413
Compare
jhrozek
previously approved these changes
Aug 21, 2024
dmjb
requested changes
Aug 21, 2024
| -- See the License for the specific language governing permissions and | ||
| -- limitations under the License. | ||
|
|
||
| BEGIN; |
JAORMX
force-pushed
the
eea-entity-instance-move
branch
from
f57b413 to
e0d5b8f
Compare
This replaces the logic from the EEA from the convoluted per-entity column to use a single reference from the central entitites table. Closes: #4168 Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
eea-entity-instance-move
branch
from
e0d5b8f to
98da2e6
Compare
dmjb
approved these changes
Aug 21, 2024
JAORMX
added a commit
that referenced
this pull request
Aug 21, 2024
This reverts commit 29c9a13. Except for the migrations, which merely added an index. Signed-off-by: Juan Antonio Osorio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces the logic from the EEA from the convoluted per-entity
column to use a single reference from the central entitites table.
Closes: #4168
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: