Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate default ID for properties, ensure the ID is not NULL #4228

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

jhrozek
Copy link
Contributor

@jhrozek jhrozek commented Aug 21, 2024

Summary

We don't want to put the onus on the user to generate the ID.

Change Type

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

as part of a larger branch

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@jhrozek jhrozek requested a review from a team as a code owner August 21, 2024 10:16
@coveralls
Copy link

coveralls commented Aug 21, 2024

Coverage Status

coverage: 53.746% (-0.008%) from 53.754%
when pulling d9fc135 on jhrozek:prop_gen_id
into 2ab6721 on stacklok:main.

We don't want to put the onus on the user to generate the ID.
@JAORMX JAORMX merged commit 2ae6637 into mindersec:main Aug 21, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants