Fix integer overflow lint errors #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjb
force-pushed
the
fix-linting-overflow
branch
from
7490297 to
03fd692
Compare
dmjb
commented
Aug 21, 2024
| @@ -78,7 +79,13 @@ var ( | |||
|
|
|||
| func init() { | |||
| // Get the terminal width, if available, and set widths based on terminal width | |||
| w, _, err := term.GetSize(int(os.Stdout.Fd())) | |||
| fd := os.Stdout.Fd() | |||
There was a problem hiding this comment.
Admittedly this check is kind of pedantic since the max FD limit is well under 2^31 on any OS I've heard of.
There was a problem hiding this comment.
This is about getting the terminal width size which is used to format the CLI tables better, not the maximum amount of file descriptors on the OS
There was a problem hiding this comment.
In that sense I don't think we should remove it
There was a problem hiding this comment.
oh, I missed expanding this and responded solely on the comment that you added. You kept the width so my comment is obsolete then 👍
dmjb
force-pushed
the
fix-linting-overflow
branch
from
03fd692 to
059fd99
Compare
Fixed through a mixture of type changes, and ignoring the linter in places where I was confident that we would never hit an overflow in practice.
dmjb
force-pushed
the
fix-linting-overflow
branch
from
059fd99 to
9caa758
Compare
rdimitrov
approved these changes
Aug 21, 2024
blkt
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of golangci introduces integer overflow checks. A number of such issues were reported in Minder upon update.
Fixed through a mixture of type changes, explicit checks, and ignoring the linter in places where I was confident that we would never hit an overflow in practice.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: