Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce central entity ID in EEA and rule eval tables #4220

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Enforce central entity ID in EEA and rule eval tables #4220

merged 1 commit into from
Aug 21, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Aug 21, 2024

Summary

These were nullable as we were introducing them into minder. Now that
we've ensured they're everywhere, we can enforce them as not null.

Fixes #4219

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@JAORMX JAORMX requested a review from a team as a code owner August 21, 2024 06:40
@coveralls
Copy link

coveralls commented Aug 21, 2024 •
edited
Loading

Coverage Status

coverage: 54.106% (+0.3%) from 53.761%
when pulling 0ac6185 on not-null-eid
into 7a0da06 on main.

@JAORMX
Enforce central entity ID in EEA and rule eval tables
0ac6185 
These were nullable as we were introducing them into minder. Now that
we've ensured they're everywhere, we can enforce them as not null.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX merged commit 2ab6721 into main Aug 21, 2024
21 checks passed
@JAORMX JAORMX deleted the not-null-eid branch August 21, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhrozek jhrozek jhrozek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce central entity table references in EEA and evaluation history tables
3 participants
@JAORMX @coveralls @jhrozek