Reapply reverted commits #4200
Merged
Reapply reverted commits #4200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4089) This change allows most of the functionality which previously used the `rule_evaluations` (and related) tables to use the new evaluation history tables instead.
dmjb
commented
Aug 19, 2024
| return errors.New("no previous alert state") | ||
| } | ||
|
|
||
| s := prevStatus.AlertStatus.AlertStatusTypes |
There was a problem hiding this comment.
Since we no longer use left joins, these values are no longer nullable. The changes in #4197 handles the case where there is no prior state.
rdimitrov
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of the three commits which were reverted, one of them was replaced by #4197 which solves the problem at source. This will undo the other two. Some changes were made to fit with the changes introduced by #4197
Validated against smoke tests by @rdimitrov. I also ran the failing smoke tests against this branch locally.
Summary
Provide a brief overview of the changes and the issue being addressed.
Explain the rationale and any background necessary for understanding the changes.
List dependencies required by this change, if any.
Fixes #(related issue)
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: